Conversation
|
agiuliano-square
left a comment
There was a problem hiding this comment.
This page is FANTASTIC! I'm obsessed. It looks like Goose made some interesting decisions WRT implementation, so I think we can clean this up a bit, but it's all small things. Great job @taniashiba!
There was a problem hiding this comment.
For consistency's sake, I think it might be better to create a "community" folder under "pages" and then put this "data" folder within that "community" folder. That way it will be structured the same way as the prompt-library folder.
There was a problem hiding this comment.
Ohhhhh gotcha! That's a good point, thank you Anthony!
| "handle": "lily-de" | ||
| } | ||
| ], | ||
| "leaderboard": [ |
There was a problem hiding this comment.
I'm curious where is this data being pulled from. I wonder if this can just be reduced to an array with each of the handles and then just use the order to determine the rank instead of having a separate "rank" field. That said, if the place you're pulling the data from structures it like this then I think it would be better to keep it as is.
There was a problem hiding this comment.
The list of people was provided to goose, which consists of all GitHub handles that goose found! Except two people, which is where I provided an avatar URL from Discord.
The rank is provided in the list given to goose by me, so it is technically already ranked! I think goose added this in case I wanted to change someone's rank after the fact as I was working through it. 🤔
| import Layout from "@theme/Layout"; | ||
| import Heading from "@theme/Heading"; | ||
|
|
||
| import styles from "./index.module.css"; |
There was a problem hiding this comment.
I don't believe this is actually used anywhere. Can probably get rid of it
There was a problem hiding this comment.
we may have to make the commits for Tania since she doesn't code regularly!
There was a problem hiding this comment.
Absolutely! I can take a stab at this. @taniashiba sorry to throw a bunch of comments at you! I wasn't sure what you're coding experience was like.
There was a problem hiding this comment.
Oh no worries at all, all comments welcome! I don't code regularly, but have a general working understanding I'd say. 😉 I do well with some guidance and pick up things faster than you'd think, I'd say! 🥺
I did work with goose to try to get rid of some of this fluff, because it kept what was no longer used from past iterations for sure!
There was a problem hiding this comment.
Thank yall for taking the time <3 If you wouldn't mind, after your review together, would you be able to give me a list of general guidelines I could give to goose to avoid leaving random bloat & making weird choices to the layout styling? 🙏 I know if I can specifically state what to do vs what not to change, I can make future changes easier!
There was a problem hiding this comment.
Of course! I think that's a great idea
| return ( | ||
| <section className="container margin-vert--lg"> | ||
| <div className="row"> | ||
| <div className="col col--12"> |
There was a problem hiding this comment.
Looks like Goose made some interesting style decisions in this file. Based on what I've seen in other files in this directory, it looks like Tailwind is the prevailing styling method. I think the whole file could probably benefit from a pass at converting everything to tailwind. I'm happy to assist with this if you'd like
There was a problem hiding this comment.
yeah i think both of us can team up and convert this to following the site's styling and format.
There was a problem hiding this comment.
That would be awesome! I tried to tell goose to use Tailwind actually, but goose just didn't change it. So I was like okay, let me leave it be for now I guess 🙏
| avatar.style.transform = 'rotate(0deg)'; | ||
| } | ||
| }} | ||
| > |
There was a problem hiding this comment.
These onMouse functions can probably be traded for hover effects. Tailwind should help with that.
| style={{ | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| padding: bgColor ? '12px' : '10px', |
There was a problem hiding this comment.
I know technically the bgColor indicates that this is a top 3 contributor, but semantically this doesn't quite read right to me. Maybe we create a separate variable to capture this and then style everything based on that variable.
| gap: '6px', | ||
| transition: 'opacity 0.3s ease' | ||
| }}> | ||
| Scroll for more ↓ |
There was a problem hiding this comment.
nit: could maybe use a background color here to improve readability
- Move community data files from src/data/community/ to src/pages/community/data/ - Rename community.tsx to community/index.tsx for better organization - Consolidate community-related files under src/pages/community/
|
Committed some changes to move to Tailwind. This is certainly not perfect, but I think it's passable for now. There are more changes I'd like to make in the future, but I think those will require larger refactors (i.e componentizing different elements, updating tailwind config, etc.) I'm happy to start to chip away at some of those refactors next quarter if folks would find that beneficial. @blackgirlbytes feel free to take a pass at this if there is anything you don't like. |
hmm @agiuliano-square yeah there are a few things I want to fix but will take me a minute. I agree that tania could merge for now and then we do a refactor. |
Thank you Rizel! I re-requested review from yall, then once it's merged the refactor can be done. Thank you so much for all your help 🥺 |
|
Made two minor CSS changes to format okay with 3 top stars vs 5, and then updated both month's team star lists. The leaderboard still includes the goose dev team and the devrel team because without them the leaderboard would be limited! |
Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Anthony Giuliano <agiuliano@squareup.com>
Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Anthony Giuliano <agiuliano@squareup.com> Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>
Co-authored-by: Tania Chakraborty <tchakraborty@block.xyz> Co-authored-by: Anthony Giuliano <agiuliano@squareup.com>



This pull request introduces an exciting new landing page:
The home to our Public Events Calendar and Community Spotlight!
community.landing.page.mov
But that's not all...
The community spotlight has also become Community All Stars program!
This program is where EVERY contributor is highlighted, including team members across Block! Here's how:
Each month, the list of all contributors to the block/goose project are pulled from GitHub, and are then analyzed and populated into the following lists by goose & @taniashiba:
The best part? This landing page was made with help from goose!
This landing page is linked in the bottom nav bar currently.
To update this community landing page each month is relatively simple:
goose/documentation/src/data/community/template.json→ rename to[month]-[year].json(e.g., june-2025.json)config.jsonin same folder • Add new month toavailableMonthsarray • UpdatedefaultMonthto show new month by defaultcommunity.tsxgoose/documentation/src/pages/community.tsxand add the import for your new JSON file at the top, add it also to thecommunityDataMapobject. For example:import june2025Datafrom "../data/community/june-2025.json"; •"june-2025": june2025Data,Quick Tips
That's basically it! You can also use goose to do this update in a commit, so long as you have the three lists mentioned above ( communityStars, teamStars, and leaderboard)